Skip to content

Fix logging crash #14388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Sep 18, 2025
Merged

Fix logging crash #14388

facebook-github-bot merged 1 commit into from
Sep 18, 2025

Conversation

@metascroy
Copy link
Contributor

@metascroy metascroy commented Sep 17, 2025

Differential Revision: D82666928

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14388

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 9af526c with merge base 5348ea9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 17, 2025

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82666928.

@github-actions
Copy link

github-actions bot commented Sep 17, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy @facebook-github-bot
Fix logging crash (pytorch#14388)
9af526c 
Summary:

The logging code will raise an uncaught exception today if message/filename are nil because adding a nil object as a value is not supported.

This checks for nil and replaces with empty string.

Reviewed By: linbinyu, shoumikhin

Differential Revision: D82666928
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 17, 2025

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82666928.

@facebook-github-bot facebook-github-bot merged commit 907fde5 into pytorch:main Sep 18, 2025
131 of 135 checks passed
@shoumikhin
Copy link
Contributor

shoumikhin commented Sep 20, 2025

@metascroy is this cherry-picked on the release branch?

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@metascroy @StrycekSimon
Fix logging crash
eabbb29 
Differential Revision: D82666928

Pull Request resolved: pytorch#14388
jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
@metascroy @jirioc
Fix logging crash
9b156bc 
Differential Revision: D82666928

Pull Request resolved: pytorch#14388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoumikhin shoumikhin shoumikhin approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@metascroy @facebook-github-bot @shoumikhin