Skip to content

HOTFIX: Handling Vec2's being False when x=0 y=0 #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DragonMoffon merged 1 commit into from
Jan 20, 2025
Merged

HOTFIX: Handling Vec2's being False when x=0 y=0 #2497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions arcade/camera/camera_2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,10 @@ def __init__(
f"projection depth is 0 due to equal {near=}" f"and {far=} values"
)

_pos = position or (half_width, half_height)
pos_x = position[0] if position is not None else half_width
pos_y = position[1] if position is not None else half_height
self._camera_data = CameraData(
position=(_pos[0], _pos[1], 0.0),
position=(pos_x, pos_y, 0.0),
up=(up[0], up[1], 0.0),
forward=(0.0, 0.0, -1.0),
zoom=zoom,
Expand Down Expand Up @@ -240,9 +241,9 @@ def from_camera_data(
render_target=render_target, window=window, viewport=viewport, scissor=scissor
)

if camera_data:
if camera_data is not None:
new_camera._camera_data = camera_data
if projection_data:
if projection_data is not None:
new_camera._projection_data = projection_data

return new_camera
Expand Down
Loading