Fix: issue-2429-Add_direction_to_ScreenShake2D #2446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The fact that this removes important methods, the double definitions of the |
Collaborator
|
Closing in favor of #2448 |
DragonMoffon
added a commit
that referenced
this pull request
Nov 13, 2024
Thank you, @bunny-therapist, for the feature request! Also adds the context manager interface, allowing for the following neat code: ```py with self.shake, self.camera.activate(): # draw commands that want to be drawn with screen shake, # outside of the with block the shake has been removed, and the camera has been deactivated. ``` closes #2429 and #2446 (Thank you for the PR, but due to the extra feature I've made my own PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix addresses an enhancement request for the ScreenShake2D class in the Arcade library by introducing an optional direction_deg parameter. This allows users to specify a constant direction for the screen shake effect, expressed in degrees. If the direction_deg parameter is not provided, the shake continues to occur randomly, as before. The fix ensures that when direction_deg is set, the shake occurs along a fixed angle, providing more control over the shake's direction while maintaining the original random behavior when the parameter is not used.