Skip to content

Fixed rand_in_circle to ensure uniform distribution of points #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushfoo merged 1 commit into from
Oct 19, 2024
Merged

Fixed rand_in_circle to ensure uniform distribution of points #2426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions arcade/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,7 @@ def rand_in_circle(center: Point2, radius: float) -> Point2:
Generate a point in a circle, or can think of it as a vector pointing
a random direction with a random magnitude <= radius.

Reference: https://stackoverflow.com/a/30564123

.. note:: This algorithm returns a higher concentration of points
around the center of the circle
Reference: https://stackoverflow.com/a/50746409

Args:
center (Point2): The center of the circle
Expand All @@ -236,7 +233,7 @@ def rand_in_circle(center: Point2, radius: float) -> Point2:
# random angle
angle = 2 * math.pi * random.random()
# random radius
r = radius * random.random()
r = radius * math.sqrt(random.random())
# calculating coordinates
return (r * math.cos(angle) + center[0], r * math.sin(angle) + center[1])

Expand Down