-
-
Notifications
You must be signed in to change notification settings - Fork 72
Enable theme translation #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for fixing what was missing with the solution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation improvement suggestions, otherwise looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for better portability
Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about right, but I'd appreciate a PR approval from a translator as well.
And we can always iterate and fix as needed after an initial release.
Maciek has already reviewed translation, see above. |
Yes, but not approved. |
In hopes of getting this in faster, I can just delete it? Fun fact, translations of the Python docs are actually not reviewed for most languages. |
Preview! (built with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks
It is no longer a follow up, it is now included in this PR! Verified manually that the artefact has the compiled files. |
Sweet! Was setup-python really necessary, considering that python is already included in the GH runner image? |
It is used in all other workflows in this repository when Python is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adds Polish to start. Based on @rffontenelle 's pr. This does not allow for translation of the Copy button for some reason, but I think that can be left for another time.
Result:
📚 Documentation preview 📚: https://python-docs-theme-previews--246.org.readthedocs.build/
🇵🇱 Polish preview 🇵🇱