Create CustomIcon as suggested in #228

[BibMartin]

Using a refactoring with ImageOverlay, you can provide an image url, file, or array.

[ocefpaf]

We needed this re-factoring! Thanks!!

@andrewgiessel this is your baby. Can take a quick look at it before we merge this?

[ocefpaf]

Beautiful!

I just re-wrote my horrible hack using this PR.

http://nbviewer.ipython.org/github/ocefpaf/secoora_assets_map/blob/gh-pages/test_geojson.ipynb

[andrewgiessel]

Yes, I'm on it! I have that and the retina PR at least

On Mon, Nov 2, 2015 at 8:39 AM Filipe notifications@github.com wrote:

Beautiful!

I just re-wrote my horrible hack using this PR.

http://nbviewer.ipython.org/github/ocefpaf/secoora_assets_map/blob/gh-pages/test_geojson.ipynb

—
Reply to this email directly or view it on GitHub
#230 (comment)
.

[andrewgiessel]

bounds is not defined here- needs to be passed into from the init method of ImageOverlay

[andrewgiessel]

This is amazing work! Other than the bounds issue I did a line comment on above, it seems like a very nice refactoring.

Do the image_overlay tests still pass? Do we more stuff there?

[BibMartin]

bounds is not defined here- needs to be passed into from the init method of ImageOverlay

Silly me ; corrected.

Do the image_overlay tests still pass? Do we more stuff there?

The test still passes ; I did not use mercator_tranform into it.
I'll add another test asap.

[ocefpaf]

@andrewgiessel Are you OK with @BibMartin's two extra commits?

[andrewgiessel]

Looks great to me, let's merge

[ocefpaf]

Looks great to me, let's merge

Done!

[Dhanesh-raj]

import os
from io import BytesIO

style_function = lambda feature: dict(fillColor='#DEFFDE',
color='#AECCAE',
weight=1,
opacity=1)
data_cm = kar_latlong
geojson = folium.GeoJson(data=country_shapes,
smooth_factor=2,
style_function=lambda x: {'color':'black','fillColor':'green','weight':1},
tooltip=folium.GeoJsonTooltip(fields=['name'],
labels=False,
sticky=True),
highlight_function=lambda x: {'weight':3,'fillColor':'grey'},
).add_to(world_map)

for i in range(0,len(data_cm)):
icon_image = BytesIO(base64.b64decode(base64.b64encode(open(os.path.join(os.getcwd(),"./icons/",data_cm.iloc[i]['CountryName']+".png"), 'rb').read())))
marker_icon = copy.copy(icon_image)
icon = CustomIcon(
marker_icon,
icon_size=(30, 30),
icon_anchor=(15, 15),
popup_anchor=(-3, -76)
)
folium.Marker(
location=[data_cm.iloc[i]['Latitude'], data_cm.iloc[i]['Longitude']],
icon = icon,
radius=float(15000.0),
popup=folium.Popup(str(data_cm.iloc[i]['CountryName']))).add_to(world_map)

folium.LayerControl(collapsed=True).add_to(world_map)
world_map.save('icon.html')
world_map

**---------------------------------------------------------------------------
NameError Traceback (most recent call last)
in
20 icon_image = BytesIO(base64.b64decode(base64.b64encode(open(os.path.join(os.getcwd(),"./icons/",data_cm.iloc[i]['CountryName']+".png"), 'rb').read())))
21 marker_icon = copy.copy(icon_image)
---> 22 icon = CustomIcon(
23 marker_icon,
24 icon_size=(30, 30),

NameError: name 'CustomIcon' is not defined**

How can I solve this? i saved my custom icons in local folder instead of using icon_url