Replace Terminal class with stdlib solution#175
Merged
Secrus merged 3 commits intopython-poetry:masterfrom Jul 16, 2022
Merged
Conversation
neersighted
approved these changes
Jul 16, 2022
Secrus
pushed a commit
to python-poetry/poetry
that referenced
this pull request
Aug 24, 2022
`cleo.terminal.Terminal` was replaced in python-poetry/cleo#175 in favor of `shutil.get_terminal_size`
branchv
added a commit
to python-poetry/poetry
that referenced
this pull request
Sep 1, 2022
`cleo.terminal.Terminal` was replaced in python-poetry/cleo#175 in favor of `shutil.get_terminal_size`
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminalclass was created back in 2016 and was useful only for versions of Python below 3.3, whenshutil.get_terminal_size()was added to stdlib.