[junit] move properties handling to finalize()
#11369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruch
force-pushed
the
fix_11367
branch
2 times, most recently
from
a095c9d to
86e29ed
Compare
nicoddemus
approved these changes
Sep 3, 2023
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @fruch, appreciate the contribution!
seem like not all the cases of calling `finalize` were adding the properties into the test case element, which leads to some test cases missing the expected properties. Fixes: pytest-dev#11367
for more information, see https://pre-commit.ci
nicoddemus
force-pushed
the
fix_11367
branch
from
bb0f356 to
22f5c53
Compare
nicoddemus
added
the
needs backport
nicoddemus
added
backport 7.4.x
and removed
needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seem like not all the cases of calling
finalizewere adding the properties into the test case element, which leads to some test cases missing the expected properties.Fixes: #11367