11028 - Fix warlus operator behavior when called by a function#11041
Merged
nicoddemus merged 5 commits intopytest-dev:mainfrom May 30, 2023
Merged
11028 - Fix warlus operator behavior when called by a function#11041nicoddemus merged 5 commits intopytest-dev:mainfrom
nicoddemus merged 5 commits intopytest-dev:mainfrom
Conversation
* refactor to handle previous test cases with walrus operator * add changelog
nicoddemus
reviewed
May 30, 2023
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Great work @aless10, thanks for tackling this so quickly, we definitely appreciate it. 👍
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10758 we introduced the support for the use of the walrus operator in the test cases. There was a case which was not handled that caused a bug report #11028. This PR aims to fix the issue and also to improve how the walrus operator is handled in the AssertionRewriter class.
closes #11028
Made during