nonpython example now repr all exceptions#11033
Merged
nicoddemus merged 1 commit intopytest-dev:mainfrom May 24, 2023
jkeifer:patch-1
Merged
nonpython example now repr all exceptions#11033nicoddemus merged 1 commit intopytest-dev:mainfrom jkeifer:patch-1
nicoddemus merged 1 commit intopytest-dev:mainfrom
jkeifer:patch-1
Conversation
The definition of `repr_failure` on the `YamlItem` subclass only handled the custom `YamlException` class, which hides all other errors from the user. By adding in the `super` call we ensure all other exception types also appropriately handled by `repr_failure`.
bluetech
approved these changes
May 24, 2023
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Yes this seems incorrect, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definition of
repr_failureon theYamlItemsubclass only handled the customYamlExceptionclass, which hides all other errors from the user. By adding in thesupercall we ensure all other exception types also appropriately handled byrepr_failure.