Perf: Skip redundant creation of Versions in specifier comparison

src/packaging/specifiers.py

@@ -32,6 +32,25 @@ def _coerce_version(version: UnparsedVersion) -> Version | None:
     return version
 
 
+def _public_version(version: Version) -> Version:
+    """Skip creation of a new Version instance if no local version to strip."""
+    if version.local is None:
+        return version
+    return Version(version.public)
+
+
+def _base_version(version: Version) -> Version:
+    """Skip creation of a new Version instance if already a base version."""
+    if (
+        version.pre is None
+        and version.post is None
+        and version.dev is None
+        and version.local is None
+    ):
+        return version
+    return Version(version.base_version)
+
+
 class InvalidSpecifier(ValueError):
     """
     Raised when attempting to create a :class:`Specifier` with a specifier
@@ -427,7 +446,7 @@ def _compare_equal(self, prospective: Version, spec: str) -> bool:
             # act as if the prospective version also does not have a local
             # segment.
             if not spec_version.local:
-                prospective = Version(prospective.public)
+                prospective = _public_version(prospective)
 
             return prospective == spec_version
 
@@ -438,13 +457,13 @@ def _compare_less_than_equal(self, prospective: Version, spec: str) -> bool:
         # NB: Local version identifiers are NOT permitted in the version
         # specifier, so local version labels can be universally removed from
         # the prospective version.
-        return Version(prospective.public) <= Version(spec)
+        return _public_version(prospective) <= Version(spec)
 
     def _compare_greater_than_equal(self, prospective: Version, spec: str) -> bool:
         # NB: Local version identifiers are NOT permitted in the version
         # specifier, so local version labels can be universally removed from
         # the prospective version.
-        return Version(prospective.public) >= Version(spec)
+        return _public_version(prospective) >= Version(spec)
 
     def _compare_less_than(self, prospective: Version, spec_str: str) -> bool:
         # Convert our spec to a Version instance, since we'll want to work with
@@ -464,7 +483,7 @@ def _compare_less_than(self, prospective: Version, spec_str: str) -> bool:
         if (
             not spec.is_prerelease
             and prospective.is_prerelease
-            and Version(prospective.base_version) == Version(spec.base_version)
+            and Version(prospective.base_version) == _base_version(spec)
         ):
             return False
 
@@ -491,15 +510,15 @@ def _compare_greater_than(self, prospective: Version, spec_str: str) -> bool:
         if (
             not spec.is_postrelease
             and prospective.is_postrelease
-            and Version(prospective.base_version) == Version(spec.base_version)
+            and Version(prospective.base_version) == _base_version(spec)
         ):
             return False
 
         # Ensure that we do not allow a local version of the version mentioned
         # in the specifier, which is technically greater than, to match.
         if prospective.local is not None and Version(
             prospective.base_version
-        ) == Version(spec.base_version):
+        ) == _base_version(spec):
             return False
 
         # If we've gotten to here, it means that prospective version is both

tests/test_specifiers.py

@@ -461,6 +461,7 @@ def test_comparison_non_specifier(self) -> None:
                 ("2.0.post1", ">2"),
                 ("2.0.post1.dev1", ">2"),
                 ("2.0+local.version", ">2"),
+                ("1.0+local", ">1.0.dev1"),
                 # Test the less than operation
                 ("2.0.dev1", "<2"),
                 ("2.0a1", "<2"),