Skip to content

Enable SymEngine for 0.4.4 see if it also passes#149

Closed
utensil wants to merge 2 commits into0.4.4-releasefrom
sym-engine
Closed

Enable SymEngine for 0.4.4 see if it also passes#149
utensil wants to merge 2 commits into0.4.4-releasefrom
sym-engine

Conversation

@utensil
Copy link
Copy Markdown
Member

@utensil utensil commented Dec 11, 2019

Don't merge, only a test. Related to #37 .

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2019

Codecov Report

Merging #149 into 0.4.4-release will increase coverage by 6.69%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           0.4.4-release     #149      +/-   ##
=================================================
+ Coverage          66.51%   73.21%   +6.69%     
=================================================
  Files                  8        8              
  Lines               4898     6275    +1377     
=================================================
+ Hits                3258     4594    +1336     
- Misses              1640     1681      +41
Impacted Files Coverage Δ
galgebra/deprecated.py 100% <0%> (+1.53%) ⬆️
galgebra/ga.py 79.52% <0%> (+5.19%) ⬆️
galgebra/utils.py 71.87% <0%> (+5.2%) ⬆️
galgebra/lt.py 49.67% <0%> (+6.57%) ⬆️
galgebra/mv.py 72% <0%> (+10.38%) ⬆️
galgebra/metric.py 81.28% <0%> (+10.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c644116...1954ceb. Read the comment docs.

@utensil utensil closed this Dec 11, 2019
@utensil utensil reopened this Dec 11, 2019
@isuruf
Copy link
Copy Markdown

isuruf commented Dec 11, 2019

If you do, from sympy import diff it'll use the sympy function regardless of the environment variable value. If you do from sympy.core.backend import diff, then diff will either be a sympy function or a symengine function depending on the environment variable.

@utensil utensil closed this Dec 17, 2019
@utensil utensil mentioned this pull request Dec 17, 2019
2 tasks
@utensil utensil added this to the 0.4.5 milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants