Skip to content

Conversation

@skyride
Copy link
Contributor

@skyride skyride commented Nov 22, 2025

There's currently a bug with the Linux release under Wayland where the copy/paste functionality doesn't work. It doesn't reliable access the clipboard as expected, so it'll silently fail to copy from clipboard, and most applications are unable to access things paste to the clipboard.

This PR fixes that by forcing it to use the actual Clipboard instead of Primary. Primary is a neat feature, but the behaviour is inconsistent if your application isn't built with its special usage in mind.

Testing

I've tested this on Wayland Linux, but I'd suggest double checking it works as expected on Windows and Mac before merging. I'm trying to see if I can get some help with that.

@DarkFenX
Copy link
Member

DarkFenX commented Nov 23, 2025

I've tested this on Wayland Linux, but I'd suggest double checking it works as expected on Windows and Mac before merging

Well that's an issue for me. I have 2 laptops, both have some flavor of linux. I might test windows build under wine, but I don't think it's a good idea for this particular change. So if you can, please try it out.

Alternatively, I can just poke friends of mine to try it and see if it works.

edit: also I am using gnome on wayland, never had issues with copy-paste

@DarkFenX
Copy link
Member

DarkFenX commented Dec 9, 2025

I will merge and test windows version via wine. Unfortunately, no mac device to test it on, but I will just be ready to make a quick fix if it breaks anything.

@DarkFenX DarkFenX merged commit 9551195 into pyfa-org:master Dec 9, 2025
1 check passed
@DarkFenX
Copy link
Member

DarkFenX commented Dec 9, 2025

Nevermind, it broke clipboard even under wayland for me. Import works fine, export does not

@DarkFenX
Copy link
Member

DarkFenX commented Dec 9, 2025

I did some "fixes" in 84fbc0a, they reverted:

  • use of new clipboard object instead of global one
  • flush call

With either of those in place, copying does not work at all for me under wayland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants