Conversation
update from pyC repo
|
Thanks @AtMostafa, this looks useful. I'll take a look ASAP but it may not be before next week. |
|
Apologies for the delay getting to this. As the changes to the analog input class are likely to be quite extensive (e.g. I'd like to address issues #26 and #16 and possibly also introduce a new analog data format to support things like multidimensional signals), I've created a new branch called new_analog_input to work on them. Please can you submit this pull request to that branch rather than the master branch. thanks, Thomas |
|
Hi @AtMostafa, I have done some work on the new_analog_input branch to make sure that all the functionallity for analog input and rotary encoder (which subclasses analog input) works with the data streaming seperated out. I also seperated out the functionallity for event generation on threshold crossing as I thought this might come in useful for either implementing multiple thresholds on a signal, or implementing thresholds on multiple components of a >1D signal. If you have time could you take a look and see if it looks like it would be compatible with your application? The next step would then be to implement datastreaming functionallity for >1D signals, which would also likely involve reworking the analog data format. |
|
Hi @ThomasAkam |
I reworked the logic of the
Analog_inputa bit to separate the data streaming from the rest of it. Now, there is aData_channelclass that only streams continuous data to the computer and is instantiated insideAnalog_input.I made the choice to not inherit from it (I believe this makes more sense) and ideally, event generation should also be independent of the
Analog_inputclass (although with changing a few lines, it could be inherited too, if that's preferred).This PR is not finished yet, in the sense that I am sure that I am breaking some of the API (functions like
_start_acquisition) and also other hardware modules such asRotary_encoderneed to be updated. It is, however, in working condition since I managed to inherit theAnalog_inputclass and instantiate anotherData_channeland send 2 independent data streams back to the PC (the x and y coordinates of the mouse sensor).