changes to run task's "setup" selection#25
Merged
ThomasAkam merged 2 commits intopyControl:devfrom Oct 5, 2021
Merged
Conversation
Contributor
alustig3
commented
Oct 5, 2021
alustig3
commented
- "select" label next to a combo box seemed redundant, so I removed it
- if no setups are found, the combo box now says "No setups found"
- size of combo box now automatically adjusts to width of items, so long setup names won't be cutoff
- select label next to a combo box seemed redundant, so I removed it - if no setups are found, the combox now says "No setups found" - size of combo box now automatically adjusts to width of items
Collaborator
|
Looks good, thanks. When testing it I noticed that the setup names in the dropdown menu were set to be editable (line 56 in run_task_tab). This was also true of the standard dev branch and does not seem to be desirable. I have made the board_select dropdown non-editable in the commit I just pushed and will now merge the pull request. |
IsabelDAlessandro
pushed a commit
to IsabelDAlessandro/pycontrol_code
that referenced
this pull request
Jan 21, 2026
changes to run task's "setup" selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.