Skip to content

Conversation

@SHAcollision
Copy link
Contributor

@SHAcollision SHAcollision commented Jan 21, 2026

Low priority
This PR changes:

  • Parse pubkyauth URLs once and route signup vs relay auth from a single path.
  • Decrease complexity of some functions and remove the clippy allow for high cognitive complexity.
  • Reuse shared token-posting helper for relay flows (signup / signin).
  • Explicitly support direct signup deeplinks (no relay/secret) without duplicating logic.
  • Updated canonical ordering of the params from mandatory first (hs) to optional last (st...) and the test expectation strings.
  • The caps param is now not enforced. By PubkyAuth standard an AuthToken with no capabilities is used to "authenticate" (prove identity). When some capabilities are requested, then it is used to "authorize" (give access to that scope). Previously caps were always enforce to exist.
  • The parsing logic now enforces relay and secret pairing: if one is present without the other, parsing fails.

@SHAcollision SHAcollision force-pushed the fix/direct-signup-deeplink-dry branch from 97a5dcd to c8b5de1 Compare January 21, 2026 12:09
@SHAcollision SHAcollision force-pushed the fix/direct-signup-deeplink-dry branch from c8b5de1 to 8f2c46f Compare January 21, 2026 13:08
@SHAcollision SHAcollision marked this pull request as ready for review January 21, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant