chore: DRY up auth approval for signup deeplinks #300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low priority
This PR changes:
pubkyauthURLs once and route signup vs relay auth from a single path.allowfor high cognitive complexity.paramsfrom mandatory first (hs) to optional last (st...) and the test expectation strings.capsparam is now not enforced. ByPubkyAuthstandard anAuthTokenwith no capabilities is used to "authenticate" (prove identity). When some capabilities are requested, then it is used to "authorize" (give access to that scope). Previouslycapswere always enforce to exist.