Fix matching of absolute paths in --include#3976
Merged
hauntsaninja merged 9 commits intopsf:mainfrom Oct 27, 2023
Merged
Conversation
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks for catching this and opening a PR! I think we should use root_relative_path on L396 , so we apply include logic before symlink resolution
Contributor
Author
|
I agree it makes sense to check include and exclude against the same type of path and not use resolved symlinks for one and unresolved symlinks for the other. It now checks the path with unresolved symlinks against includes and excludes and the symlink target is not checked this way (but it is still checked if is under the root dir). I also added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for #3975.
It modifies
normalized_pathin the way it was done before #3846, so that the check for included files still matches the same files.Checklist - did you ...
CHANGES.mdif necessary?