Skip to content

Add Caddy#1751

Merged
roidelapluie merged 1 commit intoprometheus:masterfrom
roidelapluie:caddy
Sep 26, 2020
Merged

Add Caddy#1751
roidelapluie merged 1 commit intoprometheus:masterfrom
roidelapluie:caddy

Conversation

@roidelapluie
Copy link
Member

Caddy has native prom metrics now.

Signed-off-by: Julien Pivotto roidelapluie@inuits.eu

Caddy has native prom metrics now.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
@roidelapluie
Copy link
Member Author

PR: caddyserver/caddy#3709
It is already released.

@brian-brazil
Copy link
Contributor

👍

Given the cardinality issues that have been seen with other proxy systems, it'd be wise to allow the user to configure which caddy_admin_http_requests_total labels they want.

@roidelapluie roidelapluie merged commit d6fe012 into prometheus:master Sep 26, 2020
@roidelapluie
Copy link
Member Author

Given the cardinality issues that have been seen with other proxy systems, it'd be wise to allow the user to configure which caddy_admin_http_requests_total labels they want.

cc @hairyhenderson

@hairyhenderson
Copy link

Thanks for adding this, @roidelapluie!

@brian-brazil the caddy_admin_http_requests_total metric in particular is internal and the path label (I expect that's what you're referring to) has limited cardinality (i.e. it's not just using req.URL.Path).

But, I do agree in general, and I'm planning on adding some more configurability. The initial goal was to just get some basic instrumentation enabled.

@brian-brazil
Copy link
Contributor

Ah indeed, it was the non-admin one I meant. Assembling metric names form different places makes it hard to figure out what they are from simple reading/grepping of the code.

@beorn7 beorn7 added the exporters and integrations Requests for new entries in the list of exporters and integrations label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exporters and integrations Requests for new entries in the list of exporters and integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants