Skip to content

Comments

Helm upgrade hook log streaming#1

Open
nickschuch wants to merge 36 commits intomasterfrom
helm-upgrade-hook-log-streaming
Open

Helm upgrade hook log streaming#1
nickschuch wants to merge 36 commits intomasterfrom
helm-upgrade-hook-log-streaming

Conversation

@nickschuch
Copy link
Member

No description provided.

mattfarina and others added 30 commits April 3, 2018 14:28
Adds automountServiceAccountToken when a serviceAccount is specified.

Prior to this, tiller falls back to contacting the KUBERNETES_SERVICE on
localhost:8080 rather than respecting the cluster IP in the
KUBERNETES_SERVICE_{HOST,PORT} environment variables.

Fixes helm#3460, fixes helm#3467.

(cherry picked from commit 1e03f1b)
closes helm#3795

(cherry picked from commit 09e0ab1)
(cherry picked from commit bac4f45)
(cherry picked from commit 05a1f7f)
`toYaml` was introducing a new line. It is an issue since the new line is part of a functions output, it can't be whitespace chomped away so it would require a `trimSuffix "\n"` pipe. This commit trims one trailing `\n` from the toYaml output.

(cherry picked from commit 6cdf6ce)
`toYaml` utilized by `.Files` was introducing a new line. It is an issue since the new line is part of a functions output, it can't be whitespace chomped away so it would require a `trimSuffix "\n"` pipe. This commit trims one trailing `\n` from the toYaml output.

(cherry picked from commit 35132d1)
Resolves helm#3655
We were seeing that when running helm upgrade with the reuse-values
flag enabled that you could end up in the position where overrides
a.k.a computed values from previous revisions were not being saved on
the updated revision. This left us in a weird position where some
computed values would disappear mysteriously in the abyss. That
happened because computed values from previous revisions weren't merged
with the new computed values every time the reuse-values flag was used.
This PR merges computed values from the previous revisions so you don't
end up in that kind of conundrum.

(cherry picked from commit 9266731)
fixes helm#3937

(cherry picked from commit cefee4b)
(cherry picked from commit d9395bc)
This helps tracking custom build Helm releases. The same version string
is used for Docker image tag.
Data flow:
* Kube-client returns logs to ReleaseServer using provided callbacks.
* ReleaseServer returns logs to ReleaseClient using grpc server-side streaming.

TODO: backward compatible grpc calls
(cherry picked from commit e603664)
(cherry picked from commit 8920533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.