Skip to content

Conversation

@Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Jan 1, 2026

See also #557. Since we're calling those "toggleable objects" instead of "hide/show objects", there's no potential confusion in also calling these "hidden". However, these are not objects; there's no relation to object_events. Instead, they are more like bg_events or other map events, just not declared in the same per-map files.

@Rangi42 Rangi42 requested review from dannye and vulcandth January 1, 2026 05:33
MACRO hidden_event
db \2 ; y coord
db \1 ; x coord
db \3 ; item id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this is just the event function's argument, generally speaking.

Comment on lines +601 to +604
FOR n, num_hidden_event_maps
ASSERT DEF(HiddenEventsFor_{HIDDENEVENTMAP{n}}), \
"`hidden_events_for {HIDDENEVENTMAP{n}}` is not defined"
ENDR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much redundant with:

HiddenEventPointers:
; each of these pointers is for the corresponding map in HiddenEventMaps
FOR n, num_hidden_event_maps
	dw HiddenEventsFor_{HIDDENEVENTMAP{n}}
ENDR

since the common mistake would be to forget to add a hidden_events_for / hidden_event list for some map, for example by removing:

	hidden_events_for ROUTE_4
	hidden_event 40,  3, GREAT_BALL, HiddenItems
	db -1 ; end

but then the error you'll get is Undefined symbol `HiddenEventsFor_ROUTE_4` inside of the previous dw for-loop. I think the only way to get this `hidden_events_for ROUTE_4` is not defined error message is to meddle with the previous for-loop, which a user is unlikely to do.

I'm not explicitly asking for it to be removed, but I think its value is minimal (even though its error message is nicer than the one that is superseding it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants