Skip to content

Forwardport diffing fix #4976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 1 commit into from
Dec 16, 2025
Merged

Forwardport diffing fix #4976

JoviDeCroock merged 1 commit into from
Dec 16, 2025
+135 −101

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Dec 16, 2025 •
edited
Loading

Ports #4975

@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-7.44ms - +9.90ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.09ms - +0.12ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +4% (-0.58ms - +2.40ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +3% (-0.11ms - +0.49ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.06ms - +0.84ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +2% (-0.06ms - +0.05ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.44ms - +0.34ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +3% (-1.48ms - +0.92ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: faster ✔ 1% - 13% (0.08ms - 0.85ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +5% (-0.01ms - +0.05ms)
    preact-local vs preact-main
  • todo: faster ✔ 0% - 1% (0.01ms - 0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local876.17ms - 889.75ms-unsure 🔍
-1% - +1%
-7.44ms - +9.90ms
preact-main876.33ms - 887.12msunsure 🔍
-1% - +1%
-9.90ms - +7.44ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.04ms - 19.04ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.04ms - 19.04msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.51ms - 16.71ms-unsure 🔍
-1% - +1%
-0.09ms - +0.12ms
preact-main16.57ms - 16.62msunsure 🔍
-1% - +1%
-0.12ms - +0.09ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.54ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-main1.54ms - 1.54msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local63.86ms - 66.34ms-unsure 🔍
-1% - +4%
-0.58ms - +2.40ms
preact-main63.36ms - 65.02msunsure 🔍
-4% - +1%
-2.40ms - +0.58ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.63ms - 6.15ms-faster ✔
1% - 13%
0.08ms - 0.85ms
preact-main6.06ms - 6.64msslower ❌
1% - 15%
0.08ms - 0.85ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.43ms - 17.01ms-unsure 🔍
-1% - +3%
-0.11ms - +0.49ms
preact-main16.47ms - 16.59msunsure 🔍
-3% - +1%
-0.49ms - +0.11ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.72ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5250

  • Commit: ac7f821

duration

VersionAvg timevs preact-localvs preact-main
preact-local60.93ms - 62.25ms-unsure 🔍
-2% - +1%
-1.06ms - +0.84ms
preact-main61.03ms - 62.39msunsure 🔍
-1% - +2%
-0.84ms - +1.06ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 2.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.99ms - 2.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local27.06ms - 27.84ms-unsure 🔍
-2% - +2%
-0.43ms - +0.67ms
preact-main26.94ms - 27.72msunsure 🔍
-2% - +2%
-0.67ms - +0.43ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.52ms - 34.41ms-unsure 🔍
-1% - +3%
-0.33ms - +0.99ms
preact-main33.15ms - 34.12msunsure 🔍
-3% - +1%
-0.99ms - +0.33ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local34.58ms - 35.39ms-unsure 🔍
-1% - +2%
-0.40ms - +0.78ms
preact-main34.37ms - 35.22msunsure 🔍
-2% - +1%
-0.78ms - +0.40ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.12ms - 27.50ms-unsure 🔍
-1% - +1%
-0.18ms - +0.36ms
preact-main27.02ms - 27.41msunsure 🔍
-1% - +1%
-0.36ms - +0.18ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.09ms - 26.60ms-unsure 🔍
-7% - +1%
-1.88ms - +0.22ms
preact-main25.95ms - 27.41msunsure 🔍
-1% - +7%
-0.22ms - +1.88ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.20ms - 22.66ms-unsure 🔍
-2% - +1%
-0.53ms - +0.21ms
preact-main22.30ms - 22.88msunsure 🔍
-1% - +2%
-0.21ms - +0.53ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 210
  • Built by: CI #5250

  • Commit: ac7f821

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.84ms - 1.91ms-unsure 🔍
-3% - +2%
-0.06ms - +0.05ms
preact-main1.84ms - 1.92msunsure 🔍
-2% - +3%
-0.05ms - +0.06ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.01ms - 1.05ms-unsure 🔍
-1% - +5%
-0.01ms - +0.05ms
preact-main0.99ms - 1.02msunsure 🔍
-5% - +1%
-0.05ms - +0.01ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.70ms - 32.17ms-unsure 🔍
-1% - +1%
-0.44ms - +0.34ms
preact-main31.68ms - 32.29msunsure 🔍
-1% - +1%
-0.34ms - +0.44ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.26ms - 1.26ms-faster ✔
0% - 1%
0.01ms - 0.01ms
preact-main1.26ms - 1.27msslower ❌
0% - 1%
0.01ms - 0.01ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.46ms - 31.18ms-unsure 🔍
-5% - +3%
-1.48ms - +0.92ms
preact-main29.76ms - 31.44msunsure 🔍
-3% - +5%
-0.92ms - +1.48ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.95ms - 2.96ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.95ms - 2.96msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

tachometer-reporter-action v2 for CI

JoviDeCroock
JoviDeCroock commented Dec 16, 2025
View reviewed changes
test/browser/keys.test.jsx
{children && children.length
? children
: <div class="busy-placeholder" />}
{children && children.length ? (
Copy link
Member Author

@JoviDeCroock JoviDeCroock Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, odd that the pre-commit reformats this

@JoviDeCroock JoviDeCroock changed the title Forwardport diffign fix Forwardport diffing fix Dec 16, 2025
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Size Change: +8 B (+0.02%)

Total Size: 47.5 kB

Filename Size Change
dist/preact.js 4.7 kB +3 B (+0.06%)
dist/preact.mjs 4.72 kB +3 B (+0.06%)
dist/preact.umd.js 4.78 kB +2 B (+0.04%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.91 kB
compat/dist/compat.mjs 3.84 kB
compat/dist/compat.umd.js 3.96 kB
debug/dist/debug.js 3.91 kB
debug/dist/debug.mjs 3.91 kB
debug/dist/debug.umd.js 3.99 kB
devtools/dist/devtools.js 263 B
devtools/dist/devtools.mjs 273 B
devtools/dist/devtools.umd.js 348 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.mjs 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Dec 16, 2025

Coverage Status

coverage: 99.443%. remained the same
when pulling ac7f821 on forwardport-diff-fix
into 0999ff4 on main.

@JoviDeCroock JoviDeCroock merged commit 5a02923 into main Dec 16, 2025
15 checks passed
@JoviDeCroock JoviDeCroock deleted the forwardport-diff-fix branch December 16, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoviDeCroock @coveralls @rschristian