Add connecterrlog option to log connect/disconnect script stderr.#575
Closed
jkroonza wants to merge 1 commit intoppp-project:masterfrom
Closed
Add connecterrlog option to log connect/disconnect script stderr.#575jkroonza wants to merge 1 commit intoppp-project:masterfrom
jkroonza wants to merge 1 commit intoppp-project:masterfrom
Conversation
Contributor
Author
Closes: ppp-project#574 Signed-off-by: Jaco Kroon <jaco@uls.co.za>
Member
|
@paulusmack: A new PR has been done by @jkroonza, can you look? |
Collaborator
|
I would like to hear an explanation of a use case where it is not sufficient for the user to append "2>/some/file" to the connect script. |
Contributor
Author
|
@paulusmack if it's that simple, and @betulum either confirms, or doesn't respond in a sensible time, then I suggest we discard this. |
I agree, that approach works fine. Thank you for your hint and sorry for being late with the answer. |
Member
|
Yes, I prefer it closing. Redirecting stderr, like proposed by @paulusmack , serves the same purpose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #574