Vector2: Remove cross-product #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cf ppb#70 for the rationale. TL;DR: - hard to implement in a stable and predictable way; - initially added to implement `Vector2.angle`, which doesn't use it anymore; - was never included in a release of ppb-vector.
Collaborator
Author
|
The CI failure seems to be some |
Member
|
re mypy, see python/mypy#6036 |
Member
|
I'm blocking this on resolving the discussion in #70. What algorithms depend on (or significantly benefit from) cross product, even ones not included in this library? Is the instability a deal-breaker in these cases? Can we characterize the instability? Is it something that only appears at extremes or are there perfectly reasonable vectors that have major problems? |
4 tasks
nicoonoclaste
added a commit
to nicoonoclaste/ppb-vector
that referenced
this pull request
Dec 11, 2018
I forgot to do that in ppb#80
nicoonoclaste
added a commit
to nicoonoclaste/ppb-vector
that referenced
this pull request
Dec 11, 2018
nicoonoclaste
added a commit
to nicoonoclaste/ppb-vector
that referenced
this pull request
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf #70 for the rationale. TL;DR:
Vector2.angle, which doesn't use it anymore;