Hypothesis: Add test for reflect() #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoonoclaste
force-pushed
the
hypothesis/reflect
branch
from
6e18908 to
78b0f78
Compare
Cases where cos²ϑ + sin²ϑ ≉ 1 mean that repeated rotations would diverge from the expected result, going either to 0 or infinity.
nicoonoclaste
force-pushed
the
hypothesis/reflect
branch
from
9b1f728 to
23c9aeb
Compare
Collaborator
Author
|
This should be good to go once #67 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #62The test failed without 248491f, because
tests.utils.unitsreturned not-quite-normalized vectors, becauseVector2.rotate()rounded things off.(You can check, adding.normalize()to the returned value inunits“fixes” it.)