Expose the version number programatically. #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the [feedback] I left Piper on the 1.0 release PR: i.e. the version info is now exposed programatically without duplicating it. [feedback]: ppb#23 (comment)
In order for `version = attr: ppb_vector.__version__` to work, setuptools needs to be able to import `pbb_vector`, so its runtime dependencies are now setup-time dependencies too.
Collaborator
Author
|
Thanks to @duckinator for figuring this out <3 |
Member
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 26, 2019
176: Expose the version number programatically. r=astronouth7303 a=nbraud This addresses the [feedback] I left Piper on the 1.0 release PR, _i.e._ the version info is now exposed programmatically without duplicating it across `setup.cfg` and `__init__.py`. [feedback]: #23 (comment) Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Contributor
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the feedback I left Piper on the 1.0 release PR, i.e. the version info is now exposed programmatically without duplicating it across
setup.cfgand__init__.py.