Commit to semantic versioning #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We probably want some additional documentation for ppb-vector, but for now, the API reference is all there is.
pathunstrom
approved these changes
May 31, 2019
Got a 👍 from Piper in Discord.
nicoonoclaste
changed the title
Collaborator
Author
|
@pathunstrom Sorry, I accidentally opened the PR too early (i.e. before I had commited the relevant changes >_>') @astronouth7303 I got a 👍 from Piper on Discord, re: semver, but I would prefer to have your opinion before committing to it. |
pathunstrom
approved these changes
May 31, 2019
Collaborator
pathunstrom
left a comment
pathunstrom
left a comment
There was a problem hiding this comment.
Just reconfirming, this still looks good to me.
Member
|
Yes semver good Although I suspect 2.0 will be "yeah, it's API compatible, but now it's all native" |
Collaborator
Author
|
bors r=astranouth5303,pathunstrom |
bors bot
added a commit
that referenced
this pull request
May 31, 2019
165: Commit to semantic versioning r=astranouth5303,pathunstrom a=nbraud Also snuck in 2 minor changes to `README.md`, as I didn't want to deal with conflicting PRs: - call the RTD docs “API reference”; - use complete sentences. Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Collaborator
Author
|
@astronouth7303 Why would we call it 2.0, if it's the same thing but faster? |
Contributor
Build succeeded
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also snuck in 2 minor changes to
README.md, as I didn't want to deal with conflicting PRs: