Make it so subqueries do not rewrite top-level queryId #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinderuk
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Oops, PG_FINALLY is not available in v12:
https://app.travis-ci.com/github/postgrespro/pg_wait_sampling/jobs/622953926
Medvecrab
force-pushed
the
track_top_level_queryid
branch
from
1c9e00f to
f4fbcce
Compare
shinderuk
requested changes
Jun 17, 2024
Medvecrab
force-pushed
the
track_top_level_queryid
branch
from
f4fbcce to
b2ade62
Compare
shinderuk
requested changes
Jun 17, 2024
pg_wait_sampling.c
Outdated
| PlannedStmt *result; | ||
| int i = MyProc - ProcGlobal->allProcs; | ||
| if (nesting_level == 0) | ||
| pgws_proc_queryids[i] = parse->queryId; | ||
|
|
||
| /* Invoke original hook if needed */ |
There was a problem hiding this comment.
Please move this comment below, atop if (planner_hook_next).
Medvecrab
force-pushed
the
track_top_level_queryid
branch
from
b2ade62 to
0b5c61b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove if(MyProc) checks