Wrap each migration into its own transaction#3
Open
kruszczynski wants to merge 2 commits intoporsager:masterfrom
Open
Wrap each migration into its own transaction#3kruszczynski wants to merge 2 commits intoporsager:masterfrom
kruszczynski wants to merge 2 commits intoporsager:masterfrom
Conversation
ef4a683 to
57bf965
Compare
Owner
|
Thanks :) It's fine if you put it behind an option. |
57bf965 to
14586d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I appreciate postgres-shift a lot! It's a wonderful, small, single purpose library. Thanks for creating it!
I come here with a suggestion to wrap each migration into its own transaction.
I grew up in Ruby on Rails universe and their transactions do this. As do the transactions in Ecto, Elixir's ORM.
I learned why it might be a good idea this week. I was extending a postgres Enum and then creating backfill records that used the newly created value. Instinctively I did that in separate migrations.
I didn't notice any issues in development because I ran each migration as I was writing it. Only once I shipped both migration in one PR I learned on our staging environment that one cannot create records referencing enum values added in the same transaction.
So please let me know if you'd consider adding this and releasing an updated version.
All the best,
Bartek