feat(terminal): add manual tab rename command and dialog#141
Open
niwo-gh wants to merge 2 commits intopolyipseity:mainfrom
Open
feat(terminal): add manual tab rename command and dialog#141niwo-gh wants to merge 2 commits intopolyipseity:mainfrom
niwo-gh wants to merge 2 commits intopolyipseity:mainfrom
Conversation
Add a userTitle field to TerminalView.State that lets users rename terminal tabs via pane menu or command palette. The manual title takes priority over OSC/shell-set titles and profile names; clearing it restores the previous automatic name. - State: add nullable userTitle field with fixTyped validation - UI: add rename item to pane context menu and register command - Dialog: DialogModal with text input, trim + null-on-empty - i18n: add rename keys to en locale, sync all 48 locales - Tests: add State.DEFAULT and State.fix() coverage for userTitle Resolves polyipseity#94
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userTitlefield toTerminalView.Statethat lets users manually rename terminal tabsResolves #94
Changes
userTitle: string | nullfield withfixTypedvalidation; defaults tonullrename-terminalregistered viaaddCommandwithwithLastFocusedView([false, true])DialogModalwith text input; trims whitespace, converts empty tonullenlocale (commands.rename-terminal,components.terminal.menus.rename,.rename-prompt,generic.rename); 3 icon keys inen/asset.json; all 48 non-English locales synced viasync-locale-keys.mjstests/src/terminal/view.spec.ts— coversState.DEFAULT,State.fix()with valid string, missing, non-string, boolean, null, and empty string inputsmanual-tab-rename-minor.md— minor bumpHow it works
state.userTitle; empty input clears tonullnamegetter priority chain:userTitle→ OSC title → profile name → executable basename → i18n fallbackthis.statetriggersupdateView()which refreshes the tab header and persists layoutTesting
src/import.jsto avoid xterm addon loading in the test environment