Merged
Conversation
Fixes issues 267 268 317
Clean up code Automatic restart and shutdown
- Previously a check was performed to see if the current message was sent over SSL. In cases where the message was sent as Content-Type: multipart/encrypted, the message would be improperly parsed resulting in a 401 unauthorized being sent to the client. By all accounts, the PSRP implementation on Windows in PowerShell 5 and PowerShell 6 allows a multipart/encrypted message to be sent in response to the challenge message. Since the Http_DecryptData function already ignores / returns immediately for messages that are not multipart/encrypted, this change should simply make the protocol handling more tolerant. - This fixes an issue when trying to establish a connection to an OMI server from the WinRM Ruby library where NTLM/SPNEGO is enabled in the OMI server.
- Previously a check was performed when writing headers to see if the current handler is operating over SSL. In cases where the message was sent as Content-Type: multipart/encrypted, the message response would be returned as application/soap+xml if the transport was HTTPS. This could confuse clients (such as the winrm gem) as they are expecting a response of multipart/encrypted. By all accounts, the PSRP implementation on Windows in PowerShell 5 and PowerShell 6 allows multipart/encrypted spnego messages to be sent over HTTPS. Since the code already checks for handler->encryptedTransaction prior to determining how to write response headers, it is safe to remove the SSL check to allow mulitpart/encrypted over HTTPS. This change should simply make the protocol handling more tolerant. - This fixes an issue when trying to establish a connection to an OMI server from the WinRM Ruby library where NTLM/SPNEGO is enabled in the OMI server. - Similarly change the behavior in httpclient.c to match what has been changed on the server response writing in this commit, and the server request reading in the prior commit ebe43ea
Removed runtimes/osx/native from mkdir -p runtimes/linux-x64/native
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.