Skip to content

Conversation

@mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Dec 24, 2025

Removes redundant uniform setters and consolidates camera parameter setup code.

Changes:

  • Removed unused camera_near and camera_far uniform setters from the renderer - these values are already provided via camera_params and no shaders consume the standalone uniforms
  • Added Camera.fillShaderParams() method to centralize camera params array population
  • Updated renderer, TAA render pass, and CoC render pass to use the new method, eliminating duplicate code

@mvaligursky mvaligursky self-assigned this Dec 24, 2025
@mvaligursky mvaligursky added enhancement Request for a new feature area: graphics Graphics related issue labels Dec 24, 2025
@mvaligursky mvaligursky requested a review from a team December 24, 2025 10:26
@mvaligursky mvaligursky merged commit 8e0516f into main Dec 24, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-camera-params-cleanup branch December 24, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Graphics related issue enhancement Request for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants