Fix GSplat LOD calculation to use nearest point on bounding box #8138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
added
enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves LOD (Level of Detail) selection accuracy in GSplat rendering by calculating the distance from the camera to the nearest point on an octree node's bounding box, rather than to the box center. This prevents incorrect LOD switching behavior when the camera is positioned inside or very close to large nodes.
Key Changes:
- Added
BoundingBox.closestPoint()method to find the nearest point on an AABB to a given point - Updated LOD calculation in
GSplatOctreeInstanceto use the nearest point on the bounding box - Added comprehensive test coverage for the new
closestPoint()method
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/core/shape/bounding-box.js |
Implements closestPoint() method to find the nearest point on an AABB to a given point |
test/core/shape/bounding-box.test.mjs |
Adds 16 comprehensive test cases covering various scenarios for closestPoint() |
src/scene/gsplat-unified/gsplat-octree-instance.js |
Updates calculateNodeLod() to use closestPoint() for accurate distance calculations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slimbuck
approved these changes
Nov 18, 2025
mvaligursky
added a commit
that referenced
this pull request
Nov 19, 2025
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves LOD selection accuracy by calculating distance to the nearest point
on the octree node's bounding box instead of the box center. This prevents
incorrect LOD switching when the camera is inside or near large nodes.