Adds documentation on exporting & bundling for ESM Script#752
Open
marklundin wants to merge 13 commits intomainfrom
Open
Adds documentation on exporting & bundling for ESM Script#752marklundin wants to merge 13 commits intomainfrom
marklundin wants to merge 13 commits intomainfrom
Conversation
…s" to "Classic" and "ESM Scripts" to "ESM" for consistency and clarity.
willeastcott
requested changes
May 31, 2025
Co-authored-by: Will Eastcott <will@playcanvas.com>
marklundin
commented
Jun 3, 2025
i18n/ja/docusaurus-plugin-content-docs/current/user-manual/scripting/editor-users/exporting.md
Show resolved
Hide resolved
marklundin
requested review from
Copilot and
willeastcott
and removed request for
willeastcott
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new documentation pages for exporting and bundling ESM scripts in both Japanese and English, and updates the redirect configuration accordingly.
- Adds Japanese documentation for exporting and preloading scripts
- Adds English documentation for exporting and preloading scripts
- Updates the redirect in docusaurus.config.js to point to the new exporting documentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| i18n/ja/docusaurus-plugin-content-docs/current/user-manual/scripting/editor-users/exporting.md | Added Japanese documentation on exporting and preloading scripts |
| docusaurus.config.js | Updated redirect target to the new exporting documentation |
| docs/user-manual/scripting/editor-users/exporting.md | Added English documentation on exporting and preloading scripts |
Comments suppressed due to low confidence (1)
docusaurus.config.js:46
- Ensure that the updated redirect target '/user-manual/scripting/editor-users/exporting/' is correct and that any legacy links to '/user-manual/scripting/loading-order/' are adequately handled.
{ from: ['/user-manual/scripting/loading-order/', '/en/user-manual/scripting/loading-order'], to: '/user-manual/scripting/editor-users/exporting/' },
Collaborator
Author
|
This should also be ready to go @willeastcott 🙏 |
Contributor
|
We already have this page - should it be deleted in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #751
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.