Skip to content

Conversation

@AeroNotix
Copy link
Contributor

  • Defaults to heap
  • Allows setting to allocs to output allocation tracing profile

* Defaults to `heap`
* Allows setting to `allocs` to output allocation tracing profile
Copy link
Member

@davecheney davecheney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

  1. Can you please break this down to two func options as discussed below.
  2. Can you please add examples for the new options.

Thanks

@davecheney davecheney assigned davecheney and unassigned davecheney May 1, 2020
@AeroNotix AeroNotix requested a review from davecheney May 6, 2020 23:06
Copy link
Member

@davecheney davecheney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@davecheney davecheney merged commit 57ebce6 into pkg:master May 20, 2020
@AeroNotix AeroNotix deleted the allow-override-memory-profile-type branch May 20, 2020 01:20
@AeroNotix
Copy link
Contributor Author

You're welcome. A pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants