Flash uploads not working

[dvdmierden]

Hi, With more and more browsers disabling Flash functionality lately, the swf uploadify function doesn't work for all users anymore.

Is there a way to replace this with an html5 alternative? I've tried just removing uploadify and making the form accept multipart formdata, but that doesn't work; the file is never attached to the comment or issue.

[Patriboom]

Thanks for comment.
I'm just having back my computer working (lost my HDD for no reason).
I'll try to have a look on that soon.

[Patriboom]

Hello everyone,
I'm almost there: attaching file to issue with nothing else than xtthp

Make sure you update your database which must include
table:

CREATE TABLE IF NOT EXISTS `activity` (
  `id` int(11) unsigned NOT NULL auto_increment,
  `description` varchar(255) character set UTF8 default NULL,
  `activity` varchar(255) character set UTF8 default NULL,
  PRIMARY KEY  (`id`)
) ENGINE=MyISAM DEFAULT CHARSET=utf8;

data:

INSERT IGNORE INTO `activity` (`id`, `description`, `activity`)
VALUES
	(1,'Opened a new issue','create-issue'),
	(2,'Commented on a issue','comment'),
	(3,'Closed an issue','close-issue'),
	(4,'Reopened an issue','reopen-issue'),
	(5,'Reassigned an issue','reassign-issue'),
	(6,'Updated issue tags','update-issue-tags'),
	(7,'Attached a file to issue','attached-file');

[Patriboom]

Also, be ready for that, having a

app/assets/images/icons/file_01.png file like the one attached here.

[Patriboom]

Everythings work good in editing issue.
Now, miss to give capability to attach file to a new issue.

[Patriboom]

Here we are, pull number 169
#169

[Hazaels]

So... what should I do?
Do the change on the DB manually?
As far as I understand it will fix the attachment button only when "editing issue" (on browsers like MS-Edge that do not have flash).
But it will not fix when we are "creating a new issue"?

[Patriboom]

Since yesterday, yes it does also for new issue.
If not ... just add your first comment and then attach a file.
The new attaching file system attaches files to issue without any reference to a comment. Only date and time sort items from oldest to newest (comments, tags, attached files all together).

[Hazaels]

But what I don't understand is: What will help to add one row on the database? How that will fix the flash button?
Something is missing... are you sure nothing else was changed on the code?

[Patriboom]

Are you talking about the button shown by the arrow or about another one ?

The button shown up here is deeply different from what it was before.
I worked many hours on it; I can say you the button has only the same shape and look, but what is « under » is very different.

[Patriboom]

It now gives you attached files along the issue's history.
I first took of the file's name insertion out of the comment, but i put it back.
You can see that below.

[Patriboom]

Most of the changes are visibles here: 3073926