Skip to content

Conversation

@cassandracomar
Copy link
Contributor

this PR addresses a minor annoyance. by using a script in the nix store to pass arguments to pinnacle, we've made the session launched by UWSM possess an incredibly obtuse name. this makes it difficult to e.g. check session status with the UWSM binary or to check session logs in journald. I also just missed that the extra script was unnecessary because there was an extraArgs option we could just set instead.

@cassandracomar
Copy link
Contributor Author

as an aside, are we comfortable with Pinnacle's stability at this point or do we want to let it cook a bit longer? if we're comfortable, I'll start sending PRs to nixpkgs and home-manager to get the modules upstreamed.

this PR addresses a minor annoyance. by using a script in the nix store
to pass arguments to pinnacle, we've made the session launched by UWSM
possess an incredibly obtuse name. this makes it difficult to e.g. check
session status with the UWSM binary or to check session logs in
journald.
@Ottatop
Copy link
Collaborator

Ottatop commented Jan 16, 2026

are we comfortable with Pinnacle's stability at this point or do we want to let it cook a bit longer?

I think we're good on stability. Before you upstream, I fired up a NixOS vm a few days ago and it seems you need to run cargo build to generate a Cargo.lock in the config directory before buildRustConfig can work, is that intended? I suppose it's either that or ln a new, possibly changing lockfile every rebuild which doesn't seem very reproducible.

Copy link
Collaborator

@Ottatop Ottatop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@Ottatop Ottatop merged commit 4fb8b4d into pinnacle-comp:main Jan 16, 2026
21 of 22 checks passed
@cassandracomar
Copy link
Contributor Author

Before you upstream, I fired up a NixOS vm a few days ago and it seems you need to run cargo build to generate a Cargo.lock in the config directory before buildRustConfig can work, is that intended?

yeah, there's not really a way around this. nix needs to know what dependencies to pull along with their hashes. there are ways to do this entirely in nix but it's easier for everyone to just lean on cargo's pins. that way cargo build is doing something relatively similar to nix build. there are other projects we could use to build everything within nix that would allow us to build instead with reference to the server project's lockfile but buildRustPackage isn't that sophisticated.

I think you can just run cargo lock and that will do the bare minimum to produce a lock file that nix can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants