Snowcap/Layer: improve key event handling #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ph4ntomas
force-pushed
the
snowcap-on_key_event
branch
3 times, most recently
from
1d9f273 to
ad0c3dc
Compare
Ph4ntomas
force-pushed
the
snowcap-on_key_event
branch
3 times, most recently
from
89f398b to
40d902a
Compare
Ph4ntomas
force-pushed
the
snowcap-on_key_event
branch
from
40d902a to
db3bb93
Compare
Ph4ntomas
force-pushed
the
snowcap-on_key_event
branch
from
db3bb93 to
927de0c
Compare
Ph4ntomas
force-pushed
the
snowcap-on_key_event
branch
from
927de0c to
31088e5
Compare
Ottatop
reviewed
Jan 16, 2026
Collaborator
Ottatop
left a comment
Ottatop
left a comment
There was a problem hiding this comment.
I don't know if the function should be marked as deprecated, or kept as a short-hand if only key press are needed.
Let's keep it as shorthand for now. Outside of the comments, lgtm.
Ph4ntomas
force-pushed
the
snowcap-on_key_event
branch
from
31088e5 to
f15b1f8
Compare
The on_key_pressed handler can be limiting since: - it doesn't allow to react to key being released - it doesn't transmit the processed `text` associated with keys when using a layout with dead keys. - it doesn't transmit captured events (I've added this one to conserve the previous behavior.) This commit address this by adding a on_key_event that transmit the key state, whether it was captured on the server side, and the associated text if available.
The on_key_pressed handler can be limiting since: - it doesn't allow to react to key being released - it doesn't transmit the processed `text` associated with keys when using a layout with dead keys. - it doesn't transmit captured events (I've added this one to conserve the previous behavior.) This commit address this by adding a on_key_event that transmit the key state, whether it was captured on the server side, and the associated text if available.
Ph4ntomas
force-pushed
the
snowcap-on_key_event
branch
from
f15b1f8 to
7b25a72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address a few issue I have with the current
Layer::on_key_pressedon_releaseevents (mentioned in [Request] Input Grabbing API #328).textassociated with the event (mentioned in [Request] Input Grabbing API #328).I've cherry-picked some commits from #369 (the one to emit the
textin events).To avoid breaking current config,
Layer::on_key_pressedwas mostly kept as-is, except I'm explicitly discarding events if they werecaptured, since they used to be discarded on the server side. I don't know if the function should be marked as deprecated, or kept as a short-hand if only key press are needed.I did not add
Layer::on_key_release, since:Layer::on_key_event()function.closes #374