fix(updater): optimize no inplace update

[liubog2008]

Fix #6530

[codecov-commenter]

Codecov Report

❌ Patch coverage is 82.25806% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.09%. Comparing base (06a65da) to head (1d4b2ed).

Additional details and impacted files

@@              Coverage Diff               @@
##           feature/v2    #6533      +/-   ##
==============================================
+ Coverage       40.99%   41.09%   +0.09%     
==============================================
  Files             366      366              
  Lines           20294    20328      +34     
==============================================
+ Hits             8320     8354      +34     
  Misses          11974    11974              

Flag	Coverage Δ
unittest	41.09% <82.25%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR refactors the topology-aware update policy to distinguish between scale-in and update operations, and fixes pod deletion time tracking in E2E tests.

Key changes:

• Introduces separate PolicyScaleIn() and PolicyUpdate() methods to handle different topology preferences for scaling in versus updating instances
• Updates pod watcher to use the Kubernetes watch event type for more accurate deletion time tracking
• Removes redundant WaitForInstanceListRecreated calls from E2E tests

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/e2e/utils/waiter/pod.go	Changes deletion time tracking to use watch.Deleted event instead of DeletionTimestamp for more accurate timing
tests/e2e/tiproxy/tiproxy.go	Removes redundant WaitForInstanceListRecreated calls
tests/e2e/tidb/topology.go	Removes redundant WaitForInstanceListRecreated calls
tests/e2e/tidb/tidb.go	Removes redundant WaitForInstanceListRecreated calls
tests/e2e/framework/action/test.go	Removes redundant WaitForInstanceListRecreated call
pkg/updater/policy/topology_test.go	Adds test coverage for expectedUpdatePrefered field and separate PolicyUpdate assertions
pkg/updater/policy/topology.go	Refactors TopologyPolicy interface to provide separate PolicyScaleIn() and PolicyUpdate() methods instead of a single Prefer method
pkg/updater/executor_test.go	Updates test to match new Update signature and removes unused RecordedActions method
pkg/updater/executor.go	Updates Update method signature to accept unavailable parameter and adds documentation
pkg/updater/builder.go	Reorders policy priority to put PreferUnready and PreferNotRunning first
pkg/updater/actor.go	Implements logic to handle unavailable parameter in Update method
pkg/controllers/*/tasks/updater.go	Updates all controllers to use PolicyScaleIn() method; TiDBGroup and TiProxyGroup also add PolicyUpdate()

Comments suppressed due to low confidence (2)

pkg/controllers/tsogroup/tasks/updater.go:108

• The TSO group updater is missing topoPolicy.PolicyUpdate() in its update prefer policies, while similar controllers (TiDBGroup and TiProxyGroup) include both NotLeaderPolicy() and topoPolicy.PolicyUpdate(). This inconsistency means TSO instances won't benefit from topology-aware update preferences during rolling updates.

			WithUpdatePreferPolicy(
				NotLeaderPolicy(),
			).

pkg/controllers/pdgroup/tasks/updater.go:107

• The PD group updater is missing topoPolicy.PolicyUpdate() in its update prefer policies, while similar controllers (TiDBGroup and TiProxyGroup) include both NotLeaderPolicy() and topoPolicy.PolicyUpdate(). This inconsistency means PD instances won't benefit from topology-aware update preferences during rolling updates.

			WithUpdatePreferPolicy(
				NotLeaderPolicy(),
			).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Corrected spelling of 'buut' to 'but'.

Suggested change

	return fmt.Errorf("want to update an unavailable outdated, buut choosed %s is not", name)
	return fmt.Errorf("want to update an unavailable outdated, but choosed %s is not", name)

[fgksgf]

Add WithUpdatePreferPolicy for ticdc?

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgksgf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [fgksgf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-11-10 09:37:42.473742077 +0000 UTC m=+694911.916771955: ☑️ agreed by fgksgf.