fix cross_attention, removed unused_parameters flag#236
Merged
mergify[bot] merged 2 commits intopinellolab:mainfrom Oct 13, 2023
Merged
fix cross_attention, removed unused_parameters flag#236mergify[bot] merged 2 commits intopinellolab:mainfrom
mergify[bot] merged 2 commits intopinellolab:mainfrom
Conversation
Collaborator
ssenan
commented
Oct 13, 2023
ssenan
commented
- Resolves cross attention value assignment incorrect #235
- removes the need for find_unused_parameters=True from accelerator
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 37.11% 37.11%
=======================================
Files 23 23
Lines 1482 1482
Branches 202 202
=======================================
Hits 550 550
Misses 924 924
Partials 8 8
|
cameronraysmith
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.