Skip to content

add data preprocessing notebooks into library as scripts #221

Merged
mergify[bot] merged 19 commits intopinellolab:mainfrom
ssenan:download_data
Oct 2, 2023
Merged

add data preprocessing notebooks into library as scripts #221
mergify[bot] merged 19 commits intopinellolab:mainfrom
ssenan:download_data

Conversation

@ssenan
Copy link
Collaborator

@ssenan ssenan commented Oct 1, 2023

  • Resolves add filter master data to library  #217
  • Converts main dataset curation and preprocessing notebooks into scripts for library
  • Provides tests for all new functionality + updates/removes some old placeholder tests

@ssenan ssenan added the enhancement New feature or request label Oct 1, 2023
@ssenan ssenan self-assigned this Oct 1, 2023
@ssenan ssenan marked this pull request as draft October 1, 2023 17:40
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #221 (c780c9d) into main (110eba8) will increase coverage by 4.44%.
The diff coverage is 66.03%.

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   30.67%   35.12%   +4.44%     
==========================================
  Files          20       21       +1     
  Lines        1167     1358     +191     
  Branches      155      180      +25     
==========================================
+ Hits          358      477     +119     
- Misses        804      874      +70     
- Partials        5        7       +2     
Files Coverage Δ
src/dnadiffusion/__init__.py 100.00% <100.00%> (ø)
tests/test_data_util.py 100.00% <100.00%> (ø)
tests/test_preprocessing.py 100.00% <100.00%> (ø)
tests/test_validation_preprocessing.py 100.00% <100.00%> (ø)
src/dnadiffusion/utils/data_util.py 46.32% <73.68%> (+10.60%) ⬆️
src/dnadiffusion/data/preprocessing.py 39.21% <39.21%> (ø)

@ssenan ssenan marked this pull request as ready for review October 1, 2023 23:42
@ssenan ssenan requested a review from cameronraysmith October 1, 2023 23:45
Copy link
Collaborator

@cameronraysmith cameronraysmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my comments are refactoring notes for the future.

@cameronraysmith cameronraysmith added this to the 0.1.0 milestone Oct 2, 2023
@mergify mergify bot merged commit c2648c2 into pinellolab:main Oct 2, 2023
@ssenan ssenan deleted the download_data branch October 3, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

add filter master data to library

2 participants