Skip to content

fix compare_motif_list location call in motif data frame#205

Merged
ssenan merged 18 commits intopinellolab:mainfrom
ssenan:sample
Sep 15, 2023
Merged

fix compare_motif_list location call in motif data frame#205
ssenan merged 18 commits intopinellolab:mainfrom
ssenan:sample

Conversation

@ssenan
Copy link
Collaborator

@ssenan ssenan commented Sep 15, 2023

@ssenan ssenan added the metrics modifies definition or measurement of model metrics label Sep 15, 2023
@ssenan ssenan added this to the 0.1.0 milestone Sep 15, 2023
@ssenan ssenan self-assigned this Sep 15, 2023
@ssenan ssenan changed the title Sample fix compare_motif_list location call in motif data frame Sep 15, 2023
@ssenan
Copy link
Collaborator Author

ssenan commented Sep 15, 2023

@Mergifyio queue default

@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2023

queue default

🟠 Waiting for conditions to match

Details
  • any of: [:twisted_rightwards_arrows: queue conditions]
    • all of: [:pushpin: queue conditions of queue default]
      • #approved-reviews-by>=1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • -draft [:pushpin: queue requirement]
  • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]

@pinellolab pinellolab deleted a comment from mergify bot Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #205 (4c49f0b) into main (5c9463c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   24.50%   24.50%           
=======================================
  Files          16       16           
  Lines         910      910           
  Branches      103      103           
=======================================
  Hits          223      223           
  Misses        684      684           
  Partials        3        3           
Files Changed Coverage Δ
src/dnadiffusion/metrics/metrics.py 39.47% <100.00%> (ø)
tests/test_metrics.py 100.00% <100.00%> (ø)

@ssenan ssenan merged commit 8c78c6e into pinellolab:main Sep 15, 2023
@ssenan ssenan deleted the sample branch September 15, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metrics modifies definition or measurement of model metrics

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

compare_motif_list function outputs error when used in isolation

1 participant