fix num samples outputted equal to user input#162
Merged
cameronraysmith merged 1 commit intopinellolab:mainfrom Sep 1, 2023
Merged
fix num samples outputted equal to user input#162cameronraysmith merged 1 commit intopinellolab:mainfrom
cameronraysmith merged 1 commit intopinellolab:mainfrom
Conversation
Collaborator
ssenan
commented
Jul 29, 2023
ssenan
commented
- Resolves sample.py currently doesn't allow user to create more than 10 samples per cell #161
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 11.32% 11.31% -0.02%
==========================================
Files 13 13
Lines 830 831 +1
Branches 91 93 +2
==========================================
Hits 94 94
- Misses 735 736 +1
Partials 1 1
|
Collaborator
Author
|
@cameronraysmith haven't added any tests yet, but need this merged to test some fsdp related training |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.