Skip to content

Removes torch dataloader from load_data, adds initial tests to dataloading#156

Merged
cameronraysmith merged 4 commits intopinellolab:mainfrom
ssenan:tests
Jun 27, 2023
Merged

Removes torch dataloader from load_data, adds initial tests to dataloading#156
cameronraysmith merged 4 commits intopinellolab:mainfrom
ssenan:tests

Conversation

@ssenan
Copy link
Collaborator

@ssenan ssenan commented Jun 23, 2023

@ssenan ssenan added the enhancement New feature or request label Jun 23, 2023
@ssenan ssenan added this to the 0.0.0 milestone Jun 23, 2023
@ssenan ssenan self-assigned this Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #156 (c329776) into main (a55002d) will increase coverage by 8.66%.
The diff coverage is 69.23%.

@@            Coverage Diff            @@
##            main     #156      +/-   ##
=========================================
+ Coverage   2.73%   11.39%   +8.66%     
=========================================
  Files         12       13       +1     
  Lines        805      825      +20     
  Branches      89       89              
=========================================
+ Hits          22       94      +72     
+ Misses       783      730      -53     
- Partials       0        1       +1     
Impacted Files Coverage Δ
src/dnadiffusion/data/dataloader.py 26.92% <0.00%> (+26.92%) ⬆️
src/dnadiffusion/utils/train_util.py 0.00% <0.00%> (ø)
tests/test_dataloader.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ssenan ssenan requested a review from cameronraysmith June 23, 2023 21:49
Copy link
Collaborator

@cameronraysmith cameronraysmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the tests would be run twice with the suggested change to the build workflow.

hatch run lint-check
- name: Test
run: |
hatch run test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the two adjacent lines here are the same,

test-cov-xml = "pytest -rA --cov-report=xml"

this should be redundant (i.e. the new functionality would essentially run the tests twice).

@cameronraysmith cameronraysmith merged commit 34502e5 into pinellolab:main Jun 27, 2023
@ssenan ssenan deleted the tests branch September 13, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

torch dataloader tied to preprocessing function

2 participants