Removes torch dataloader from load_data, adds initial tests to dataloading#156
Merged
cameronraysmith merged 4 commits intopinellolab:mainfrom Jun 27, 2023
Merged
Removes torch dataloader from load_data, adds initial tests to dataloading#156cameronraysmith merged 4 commits intopinellolab:mainfrom
cameronraysmith merged 4 commits intopinellolab:mainfrom
Conversation
Collaborator
ssenan
commented
Jun 23, 2023
- Resolve torch dataloader tied to preprocessing function #155
- Moves the torch dataloader instantiation to train_util class
- Adds tests to SequenceDataset class that is used to instantiate dataloader
- Adds hatch run test to build workflow
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
=========================================
+ Coverage 2.73% 11.39% +8.66%
=========================================
Files 12 13 +1
Lines 805 825 +20
Branches 89 89
=========================================
+ Hits 22 94 +72
+ Misses 783 730 -53
- Partials 0 1 +1
|
cameronraysmith
requested changes
Jun 26, 2023
Collaborator
cameronraysmith
left a comment
There was a problem hiding this comment.
Perhaps the tests would be run twice with the suggested change to the build workflow.
.github/workflows/build.yml
Outdated
| hatch run lint-check | ||
| - name: Test | ||
| run: | | ||
| hatch run test |
Collaborator
There was a problem hiding this comment.
Since the two adjacent lines here are the same,
Line 141 in a55002d
this should be redundant (i.e. the new functionality would essentially run the tests twice).
cameronraysmith
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.