Skip to content

pytorch-lightning/hydra-zen integration#105

Merged
cameronraysmith merged 18 commits intopinellolab:dna-diffusionfrom
ssenan:pl-clean
Mar 21, 2023
Merged

pytorch-lightning/hydra-zen integration#105
cameronraysmith merged 18 commits intopinellolab:dna-diffusionfrom
ssenan:pl-clean

Conversation

@ssenan
Copy link
Collaborator

@ssenan ssenan commented Mar 21, 2023 •
edited by cameronraysmith
Loading

Some of the additions:

  • configs.py: contains a hydra-zen config that incorporates our current training parameters 144a70c
  • train_lightning.py: integrates hydra-zen config into training loop that utilizes LightningTrainer 573bb9f
  • adds sampling loop as a callback 742be56
  • updates dataloader to include a LightningDataModule 693196f
  • integrates current model into a LightningModule a210703
  • There are many other small code structure changes that can be observed in history

ssenan added 16 commits March 21, 2023 20:54
@ssenan
Updating trainer in line with fabric convention
6857377
@ssenan
Added new folders to gitignore
fd93311
@ssenan
Added LightningDataModule to dataloader and updated base LoadingData …
693196f 
…to be more readable
@ssenan
created new sampling callback, ema callback is still wip
742be56
@ssenan
fixed line-length in precommit
d7e19ee
@ssenan
split networks.py into the building modules and the main unet
d34cccd
@ssenan
create hydra-zen configs.py file
144a70c
@ssenan
unet lightningmodule created
a210703
@ssenan
separated sampling and validation metrics
2ae3612
@ssenan
fixed an error where timestep wasn't on correct device during inference
74dc7a1
@ssenan
removing fabric trainer script, may revisit in the future
fef5325
@ssenan
resolving a gimmemotif error that occurs during sampling, old method …
9e38246 
…commented out
@ssenan
added wandb outputs folder to .gitignore
7bc7fa4
@ssenan
added main lightning trainer script that uses hydra-zen config
573bb9f
@ssenan
changing step_ema epoch from 2000 to 100
0fc0faa
@ssenan
adding new encode_data.pkl file for reference
cf31ab1
@ssenan ssenan added enhancement New feature or request codebase labels Mar 21, 2023
@ssenan ssenan added this to the 0.0.1 milestone Mar 21, 2023
@ssenan ssenan requested a review from cameronraysmith March 21, 2023 21:33
@ssenan ssenan self-assigned this Mar 21, 2023
This was linked to issues Mar 21, 2023
Create a Data Loader Class with Pytorch Lightning #12
Closed
use hydra-zen for configuration #102
Closed
Integrate PyTorch Ligthning for distributed training #3
Closed
cameronraysmith
cameronraysmith requested changes Mar 21, 2023
View reviewed changes
@cameronraysmith cameronraysmith merged commit 3b6c6eb into pinellolab:dna-diffusion Mar 21, 2023
@ssenan ssenan deleted the pl-clean branch March 21, 2023 22:20
@cameronraysmith cameronraysmith mentioned this pull request Mar 25, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cameronraysmith cameronraysmith cameronraysmith approved these changes

@cmvcordova cmvcordova Awaiting requested review from cmvcordova

@mateibejan1 mateibejan1 Awaiting requested review from mateibejan1

@LucasSilvaFerreira LucasSilvaFerreira Awaiting requested review from LucasSilvaFerreira

Assignees

@ssenan ssenan

Labels

codebase enhancement New feature or request

Projects

DNA-Diffusion
Status: Done

Milestone

0.0.1

Development

Successfully merging this pull request may close these issues.

use hydra-zen for configuration Create a Data Loader Class with Pytorch Lightning Integrate PyTorch Ligthning for distributed training

2 participants

@ssenan @cameronraysmith