Skip to content

[BUG] DOMElement's reactRoot doesn't need to be removed from parentNode if parent already destroyed. #22

@trusktr

Description

@trusktr

Here's a temporary fix:

DOMElement.prototype._famousReactRootDestroy = function _famousReactRootDestroy() {
    let reactRoot = this._famousReactRoot;
    if (reactRoot) {
        this._famousUnmountReact(reactRoot);
        if (reactRoot.parentNode)
            reactRoot.parentNode.removeChild(reactRoot);
        this._famousReactRoot = null;
    }
}

the difference is checking if (reactRoot.parentNode). Seems like it's null due to some prior cleanup steps.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions