More precise ignore_user_abort() return type#2489
Merged
ondrejmirtes merged 1 commit intophpstan:1.10.xfrom Jun 26, 2023
Merged
More precise ignore_user_abort() return type#2489ondrejmirtes merged 1 commit intophpstan:1.10.xfrom
ondrejmirtes merged 1 commit intophpstan:1.10.xfrom
Conversation
Collaborator
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
staabm
force-pushed
the
ignore_user_abort
branch
from
15927c0 to
34636c4
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as we recently stumbled over this functions return type I figured it would be helpful to cover this more precisely in PHPStan.
The setter expects a bool, but the getter returns a int.
https://3v4l.org/jmCa8
https://www.php.net/manual/en/function.ignore-user-abort.php