Skip to content

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jan 4, 2024

No description provided.

@staabm
Copy link
Contributor Author

staabm commented Jan 4, 2024

should I do @require-implements in this very same PR?

edit: just realized I am missing the "printing" parts

@staabm staabm marked this pull request as ready for review January 4, 2024 16:44
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please add @phpstan-require-implements here too.

/**
* @return RequireExtendsTagValueNode[]
*/
public function getRequireExtendsTagValues(string $tagName = '@require-extends'): array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar tag has a prefix here by default:

public function getTypeAliasImportTagValues(string $tagName = '@phpstan-import-type'): array
(We don't need to support and test prefix-less variant).

@ondrejmirtes ondrejmirtes merged commit bd84b62 into phpstan:1.23.x Jan 4, 2024
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the require-extends branch January 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants