Skip to content

Fixed #15440 page number not showing in url bug#15464

Merged
williamdes merged 1 commit intophpmyadmin:QA_4_9from
ankush-0x90:designer_pg_no_fix
Sep 8, 2019
Merged

Fixed #15440 page number not showing in url bug#15464
williamdes merged 1 commit intophpmyadmin:QA_4_9from
ankush-0x90:designer_pg_no_fix

Conversation

@ankush-0x90
Copy link
Contributor

@ankush-0x90 ankush-0x90 commented Sep 8, 2019

Signed-off-by: Ankush Patil aspraz2658@gmail.com

Description

Page number not reflecting in the url after saving as new page in designer, Issue was fixed by loading the page again..
Fixes #15440

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@ankush-0x90
Fixed #15440 page number not showing in url bug
3b9eb2b 
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
williamdes added a commit that referenced this pull request Sep 8, 2019
@williamdes
Fix #15440 - Page number is not being updated in the URL after saving…
f49c253 
… a designer's page

Fixes: #15440
Pull-request: #15464
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 3b9eb2b into phpmyadmin:QA_4_9 Sep 8, 2019
@williamdes williamdes self-assigned this Sep 8, 2019
@williamdes williamdes added this to the 4.9.1 milestone Sep 8, 2019
williamdes
williamdes reviewed Sep 8, 2019
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @asprazz !

@ankush-0x90 ankush-0x90 deleted the designer_pg_no_fix branch September 8, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamdes williamdes williamdes left review comments

Assignees

@williamdes williamdes

Labels

None yet

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@ankush-0x90 @williamdes