Skip to content

Fix phpmyadmin #15287 : Fix auto_increment field is too small#15294

Merged
williamdes merged 1 commit intophpmyadmin:QA_4_8from
ankush-0x90:auto_increment_input_fix
May 27, 2019
Merged

Fix phpmyadmin #15287 : Fix auto_increment field is too small#15294
williamdes merged 1 commit intophpmyadmin:QA_4_8from
ankush-0x90:auto_increment_input_fix

Conversation

@ankush-0x90
Copy link
Contributor

@ankush-0x90 ankush-0x90 commented May 27, 2019

Signed-off-by: Ankush Patil aspraz2658@gmail.com

Description

As per issue #15287 : The auto_increment field only shows 5 most significant digits of numbers greater than 99999. Fixed using adding css style to id of the input field.

Fixes #15287

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @asprazz !

@williamdes williamdes merged commit 61a62f4 into phpmyadmin:QA_4_8 May 27, 2019
williamdes added a commit that referenced this pull request May 27, 2019
Fixes: #15287
Pull-request: #15294
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes added this to the 4.8.6 milestone May 27, 2019
@williamdes williamdes self-assigned this May 27, 2019
@williamdes
Copy link
Member

@asprazz Your contribution will be part of 4.8.6 !

@ankush-0x90
Copy link
Contributor Author

@asprazz Your contribution will be part of 4.8.6 !

Thank You Sir. It really feels great when your PR gets merged. 🥇 :)

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #15294 into QA_4_8 will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             QA_4_8   #15294   +/-   ##
=========================================
  Coverage     55.58%   55.58%           
  Complexity    14497    14497           
=========================================
  Files           494      494           
  Lines         71048    71048           
=========================================
  Hits          39494    39494           
  Misses        31554    31554

1 similar comment
@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #15294 into QA_4_8 will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             QA_4_8   #15294   +/-   ##
=========================================
  Coverage     55.58%   55.58%           
  Complexity    14497    14497           
=========================================
  Files           494      494           
  Lines         71048    71048           
=========================================
  Hits          39494    39494           
  Misses        31554    31554

@williamdes
Copy link
Member

Thank You Sir. It really feels great when your PR gets merged. 1st_place_medal :)

Yes, indeed !
You can contribute to fix other issues is you want ;)

@ankush-0x90 ankush-0x90 deleted the auto_increment_input_fix branch May 29, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants