Security: remove possibility of token leak #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build artifact that is passed between jobs included the .git directory, which contained a config file that stored an access token.
The token inside the file was automatically revoked as soon as the Github Action was completed, but there is a feasibility that under an attack condition, this token could be kept alive. See the documentation at https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication
To resolve any potential token leakage, the .git directory is not included within the build artifact, and on top of this, the token permissions are explicitly set in the workflow file.